Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Example of Multiview MIGHT and Forest #142

Merged
merged 11 commits into from
Oct 16, 2023
Merged

[DOC] Example of Multiview MIGHT and Forest #142

merged 11 commits into from
Oct 16, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Oct 12, 2023 •
edited
Loading

Closes #88
Closes #112

Changes proposed in this pull request:

  • an example of multi-view random forest
  • an example of co-MIGHT (e.g. hypothesis testing with multi view random forest)

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@adam2392
Adding multiview example
ea8ce18 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Merge main
3ac096e 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
merge main
a74f3e7 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Temp wip
139219e 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Merging main
fdd174f 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Adding multiview dtc example
ce36d7b 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Organize examples
c206463 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 marked this pull request as ready for review October 12, 2023 19:53
@adam2392 adam2392 mentioned this pull request Oct 12, 2023
Closed
@adam2392
Fix docs
c34f206 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Fix docs
92a79e8 
Signed-off-by: Adam Li <adam2392@gmail.com>
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (64b8044) 89.73% compared to head (993c30f) 89.73%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files          41       41           
  Lines        3352     3352           
=======================================
  Hits         3008     3008           
  Misses        344      344

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam2392
Adding imbalanced MIGHT example
993c30f 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Copy link
Collaborator Author

Rendered artifacts:

https://output.circle-artifacts.com/output/job/0521793e-4ff3-44fe-a270-ba882be3e601/artifacts/0/dev/auto_examples/hypothesis_testing/plot_MI_imbalanced_hyppo_testing.html

and

https://output.circle-artifacts.com/output/job/0521793e-4ff3-44fe-a270-ba882be3e601/artifacts/0/dev/auto_examples/multiview/plot_multiview_dtc.html

sampan501
sampan501 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@sampan501 sampan501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looked over this before and forgot to approve

@adam2392 adam2392 merged commit 486e5a2 into main Oct 16, 2023
26 checks passed
@adam2392 adam2392 deleted the multiviewex branch October 16, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampan501 sampan501 sampan501 approved these changes

@jovo jovo Awaiting requested review from jovo

@SUKI-O SUKI-O Awaiting requested review from SUKI-O

@PSSF23 PSSF23 Awaiting requested review from PSSF23

@YuxinB YuxinB Awaiting requested review from YuxinB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add multiview code/docs/tutorial Multi-view MORF with multiple feature sets
2 participants
@adam2392 @sampan501